Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): add config to skip pulling test images #1466

Merged
merged 3 commits into from
Apr 24, 2023
Merged

chore(test): add config to skip pulling test images #1466

merged 3 commits into from
Apr 24, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1465

@andrewazores andrewazores requested a review from ebaron as a code owner April 22, 2023 05:01
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Apr 22, 2023
@mergify mergify bot added the safe-to-test label Apr 22, 2023
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. and removed needs-triage Needs thorough attention from code reviewers labels Apr 22, 2023
@andrewazores andrewazores requested a review from maxcao13 April 22, 2023 14:34
This was referenced Apr 22, 2023
Merged
Closed
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1466-68a5bea1afc28f31321d0d34c2ae23fa29a7350a sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1466-bcac5a66dcddd9dbf52fb24918cce85041856b7d sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1466-bcac5a66dcddd9dbf52fb24918cce85041856b7d sh smoketest.sh

maxcao13
maxcao13 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@andrewazores
Copy link
Member Author

Needs review from @ebaron as well since this touches the pom.xml

@andrewazores andrewazores merged commit 043ea78 into cryostatio:main Apr 24, 2023
@andrewazores andrewazores deleted the pull-images-flag branch April 24, 2023 22:25
mergify bot pushed a commit that referenced this pull request Apr 24, 2023
@andrewazores @mergify
chore(test): add config to skip pulling test images (#1466)
8d37380 
* chore(test): add config to skip pulling test images

* add env var handling to integration test script

* correct reports JDP config

(cherry picked from commit 043ea78)
@mergify mergify bot mentioned this pull request Apr 24, 2023
Merged
andrewazores added a commit that referenced this pull request Apr 24, 2023
@mergify @andrewazores
chore(test): add config to skip pulling test images (#1466) (#1470)
3e0e399 
* chore(test): add config to skip pulling test images

* add env var handling to integration test script

* correct reports JDP config

(cherry picked from commit 043ea78)

Co-authored-by: Andrew Azores <aazores@redhat.com>
@maxcao13 maxcao13 mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 approved these changes

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Allow skipping of test container image pulls
3 participants
@andrewazores @ebaron @maxcao13